For all their outward chumminess, the course of true love has not run smoothly between Sandy Weill and John Reed, the co-chairmen and co-chief executives of the financial-services giant since it was formed in April 1998 by the merger of Citibank and Travelers.